license: allow grouping of licenses with AND or OR clauses#2050
Open
sil2100 wants to merge 5 commits intochainguard-dev:mainfrom
Open
license: allow grouping of licenses with AND or OR clauses#2050sil2100 wants to merge 5 commits intochainguard-dev:mainfrom
sil2100 wants to merge 5 commits intochainguard-dev:mainfrom
Conversation
Signed-off-by: Łukasz 'sil2100' Zemczak <lukasz.zemczak@chainguard.dev>
Signed-off-by: Łukasz 'sil2100' Zemczak <lukasz.zemczak@chainguard.dev>
Signed-off-by: Łukasz 'sil2100' Zemczak <lukasz.zemczak@chainguard.dev>
Member
Author
|
I am still not sure if the naming isn't a bit confusing. I think it would help if instead of |
Signed-off-by: Łukasz 'sil2100' Zemczak <lukasz.zemczak@chainguard.dev>
Member
Author
|
Should we go more with something like this? |
Contributor
Something like this somehow feels more natural: licensing:
- path:
- "src/"
- "include"
license:
- and:
- or:
- GPL-v2
- Apache-2.0
- BSD-3-Clause
- path:
- "third_party/"
license:
- "MIT/"I'm sure there's bugs in that, but you get what i mean. It feels akin to the |
Member
Author
|
hm, this is possible, however still confusing to look at. And using a structure similar to mine allows to add attestations as part of each license file easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The world of licensing is complex. Some software is dual-licensed, some requires following multiple licenses. Let's add the ability to group licenses by AND and OR groupings. This is all optional.
Adds support for groupings in the rennovator. Now calling
melange license-check --fix --structured package.yamlwill attempt in creating a structured grouped license list.